Hugo update - #359
Conversation
|
Tested, seems to work. |
curly brackets did not go well with the hugo update #359
|
Update: |
|
Note: I get error messages when trying to |
|
There is still a major issue to be discussed with maintainers: Sidenote: I also removed our twitter link. Related IssueLoosely related to PR #375 which was merged in here; TODOs before merging:
|
The `minimo` theme seems unmaintained; at least it still contains deprecated hugo syntax. This is fixed by selectively copying affected files from the `themes/minimo/<...>` subfolders to the main hugo folder. Those files are now under our maintenance and may be removed in the future if `minimo` receives and update.
- actions/checkout v7.0.1 - actions/upload-artifact v7.0.1 - c-hive/gha-remove-artifacts v1.8.0 - peaceiris/actions-hugo v3.2.1 - JamesIves/github-pages-deploy-action v4.9.0 ... and decided to revert to the official `minimo` repo instead of my own fork (modifications now live directly in this repo, see previous commit).
|
@damianooldoni I just fast-forwarded everything to the latest versions again:
Creation of the artifact works, so I assume that website deployment should also work upon merge to (*) Because I included the GHA, this PR now effectively overwrites #375 and the other PR may be closed. Sorry for this; I only realized afterwards that I was working on the same files as @ElsLommelen . Please double check, but I think we can safely close #375 after merging #359 . If anything is unclear from my writing, please do not hesitate to PM me. |
damianooldoni
left a comment
There was a problem hiding this comment.
Hi @falkmielke! Thanks for this update.
I tested locally on my Windows machine and everything looks fine 🥳
I just want to share a small config detail not mentioned in the README I had to change in order to render the website locally.
I installed Go and Hugo (last time I rendered the website was on another laptop): so, I am using hugo v0.166.0 and Go v1.27.1.
I needed to replace {{ template "_internal/google_analytics_async.html" . }} in themes/minimo/layouts/partials/head/analytics.html with {{ template "_internal/google_analytics.html" . }} to solve the error:
ERROR html/template:_partials/head/analytics.html:1:13: no such template "_internal/google_analytics_async.html"
I wonder if you had to do this as well. Notice that this ignored as it is just used for local rendering to "simulate" the rendering process on GitHub Pages.
|
Thank you for testing, @damianooldoni !
Interesting. I did not have to change this. |
|
For reference, follow-up on the open checkbox points above:
The theme was temporarily replaced by a fork, but I lack capacity to maintain that. For the moment, I decided to revert, linking to
These were updated, using immutable commit hashes, and will require more regular updates in the future. |
Description
The Hugo build instructions were a bit dated.
The site would not build locally any more.
More errors were related to changed partials from the
minimotheme.I have also attempted to update the github actions workflow.
This is the attempt to migrate to the latest versions of hugo and minimo.